Skip to content

Use List.of() and Set.of() where feasible #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jan 8, 2025

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 8, 2025
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 13, 2025
@mp911de mp911de self-assigned this Jan 13, 2025
@kse-music
Copy link

kse-music commented Jan 17, 2025

Note that Arrays.asList is mutable and List.of is not. Switching to an immutable Collection would be considered as a breaking change.

@quaff
Copy link
Contributor Author

quaff commented Jan 17, 2025

Note that Arrays.asList is mutable and List.of is not. Switching to an immutable Collection would be considered as a breaking change.

So I didn't replace all Arrays.asList().

@mp911de mp911de changed the title Use (List|Set).of() where feasible Use List.of() and Set.of() where feasible May 9, 2025
@mp911de mp911de added this to the 3.3.12 (2024.0.12) milestone May 9, 2025
@mp911de mp911de closed this in b4d2391 May 9, 2025
mp911de pushed a commit that referenced this pull request May 9, 2025
mp911de pushed a commit that referenced this pull request May 9, 2025
@mp911de
Copy link
Member

mp911de commented May 9, 2025

Thank you for your contribution. That's merged and backported now.

mp911de pushed a commit that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants